Issue 657173002: Guard against the app launcher having a custom start page URL.

Issue 657173002: Guard against the app launcher having a custom start page URL. (Closed)

Created:
6 years, 2 months ago by Anand Mistry (off Chromium)

Modified:
6 years, 2 months ago

Reviewers:
calamity

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, Matt Giuca

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Guard against the app launcher having a custom start page URL. Non chrome:// URLs don't have WebUI objects. BUG=423278 Committed: https://crrev.com/69ccb323be58ff1d3cc9cb802b5e656832c8ccdb Cr-Commit-Position: refs/heads/master@{#300133}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/browser/ui/app_list/start_page_service.cc	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 10 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657173002/20001

6 years, 2 months ago (2014-10-17 17:22:01 UTC) #8

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 18:27:31 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/69ccb323be58ff1d3cc9cb802b5e656832c8ccdb
Cr-Commit-Position: refs/heads/master@{#300133}