Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657163002: Simplify server_dirs algorithm. os.path.join('/foo', '/bar') gives '/bar'. (Closed)

Created:
6 years, 2 months ago by slamm
Modified:
6 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Simplify server_dirs algorithm. os.path.join('/foo', '/bar') gives '/bar'. BUG= Committed: https://crrev.com/db283871c5ff384e537faa453ef631a7245237c6 Cr-Commit-Position: refs/heads/master@{#299772}

Patch Set 1 #

Patch Set 2 : Remove an unrelated refactor. #

Total comments: 2

Patch Set 3 : Make servings_dirs a read-only property. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M tools/telemetry/telemetry/page/page_set.py View 1 2 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
slamm
Small refactor.
6 years, 2 months ago (2014-10-15 18:49:13 UTC) #2
nednguyen
https://codereview.chromium.org/657163002/diff/20001/tools/telemetry/telemetry/page/page_set.py File tools/telemetry/telemetry/page/page_set.py (right): https://codereview.chromium.org/657163002/diff/20001/tools/telemetry/telemetry/page/page_set.py#newcode46 tools/telemetry/telemetry/page/page_set.py:46: for d in serving_dirs or []) Since you are ...
6 years, 2 months ago (2014-10-15 20:15:01 UTC) #3
slamm
Make servings_dirs a read-only property.
6 years, 2 months ago (2014-10-15 20:27:29 UTC) #4
slamm
https://codereview.chromium.org/657163002/diff/20001/tools/telemetry/telemetry/page/page_set.py File tools/telemetry/telemetry/page/page_set.py (right): https://codereview.chromium.org/657163002/diff/20001/tools/telemetry/telemetry/page/page_set.py#newcode46 tools/telemetry/telemetry/page/page_set.py:46: for d in serving_dirs or []) On 2014/10/15 20:15:01, ...
6 years, 2 months ago (2014-10-15 20:28:25 UTC) #5
nednguyen
lgtm
6 years, 2 months ago (2014-10-15 20:31:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657163002/40001
6 years, 2 months ago (2014-10-15 20:31:57 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-15 21:29:50 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:30:31 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/db283871c5ff384e537faa453ef631a7245237c6
Cr-Commit-Position: refs/heads/master@{#299772}

Powered by Google App Engine
This is Rietveld 408576698