Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 657143002: Set an href for the extension options pages link to get the correct mouse over (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 594f901517cbd210aec4bc6daca6d7179e36e758..56eac8c0256443724e23e90f2f8f19846bdd9769 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -279,6 +279,10 @@ cr.define('options', function() {
var options, optionsClickListener;
if (extension.optionsOpenInTab) {
options = node.querySelector('.options-link');
+ // Set an href to get the correct mouse-over appearance (link,
+ // footer) - but the actual link opening is done through chrome.send
+ // with a preventDefault().
+ options.setAttribute('href', extension.optionsPageHref);
optionsClickListener = function() {
chrome.send('extensionSettingsOptions', [extension.id]);
};
« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698