Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: mojo/services/public/interfaces/network/tcp_server_socket.mojom

Issue 657113002: Add basic TCP socket mojo implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/network/tcp_server_socket.mojom
diff --git a/mojo/services/public/interfaces/network/tcp_server_socket.mojom b/mojo/services/public/interfaces/network/tcp_server_socket.mojom
index 997f7e841736a7727bafb7079f44d04ba4e8bba2..1625559adbc29ebe2061193b475cd243ca4a4cf0 100644
--- a/mojo/services/public/interfaces/network/tcp_server_socket.mojom
+++ b/mojo/services/public/interfaces/network/tcp_server_socket.mojom
@@ -14,6 +14,10 @@ interface TCPServerSocket {
// for connecting with the remote host. Only one Accept call can be pending
// at a time.
//
+ // Once a connection has been established i(indicated by a successful
yzshen1 2014/10/15 21:07:44 nit: an extra 'i'
+ // callback), the TCPConnectedSocket may outlive the TCPServerSocket that
+ // created it.
+ //
// On success, the address of the remote host will be provided.
Accept(handle<data_pipe_consumer> send_stream,
handle<data_pipe_producer> receive_stream,

Powered by Google App Engine
This is Rietveld 408576698