Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: mojo/services/network/network_service_impl.cc

Issue 657113002: Add basic TCP socket mojo implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/network/network_service_impl.cc
diff --git a/mojo/services/network/network_service_impl.cc b/mojo/services/network/network_service_impl.cc
index a622322ebb74d8c390155ca9bd039f740415fd7f..6f2f5502d645d78dbf466e2e3558922814fe6d0f 100644
--- a/mojo/services/network/network_service_impl.cc
+++ b/mojo/services/network/network_service_impl.cc
@@ -14,19 +14,6 @@
namespace mojo {
-namespace {
-
-// Allows a Callback<NetworkErrorPtr, NetAddressPtr> to be called by a
-// Callback<NetworkErrorPtr> when the address is already known.
-void BoundAddressCallbackAdapter(
- const Callback<void(NetworkErrorPtr, NetAddressPtr)>& callback,
- NetAddressPtr address,
- NetworkErrorPtr err) {
- callback.Run(err.Pass(), address.Pass());
-}
-
-} // namespace
-
NetworkServiceImpl::NetworkServiceImpl(ApplicationConnection* connection,
NetworkContext* context)
: context_(context),
@@ -70,19 +57,10 @@ void NetworkServiceImpl::CreateTCPConnectedSocket(
ScopedDataPipeProducerHandle receive_stream,
InterfaceRequest<TCPConnectedSocket> client_socket,
const Callback<void(NetworkErrorPtr, NetAddressPtr)>& callback) {
- TCPBoundSocketImpl bound_socket;
- int net_error = bound_socket.Bind(NetAddressPtr());
- if (net_error != net::OK) {
- callback.Run(MakeNetworkError(net_error), NetAddressPtr());
- return;
- }
-
- bound_socket.Connect(
- remote_address.Pass(), send_stream.Pass(), receive_stream.Pass(),
- client_socket.Pass(),
- base::Bind(&BoundAddressCallbackAdapter,
- callback,
- base::Passed(bound_socket.GetLocalAddress().Pass())));
+ // TODO(brettw) implement this. We need to know what type of socket to use
+ // so we can create the right one (i.e. to pass to TCPSocket::Open) before
+ // doing the connect.
+ callback.Run(MakeNetworkError(net::ERR_NOT_IMPLEMENTED), NetAddressPtr());
}
void NetworkServiceImpl::CreateUDPSocket(InterfaceRequest<UDPSocket> socket) {

Powered by Google App Engine
This is Rietveld 408576698