Add basic TCP socket mojo implementation

mojo/services/network/tcp_connected_socket_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SERVICES_NETWORK_TCP_CONNECTED_SOCKET_H_
 #define MOJO_SERVICES_NETWORK_TCP_CONNECTED_SOCKET_H_
 
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+#include "mojo/common/handle_watcher.h"
 #include "mojo/public/cpp/bindings/interface_impl.h"
 #include "mojo/services/public/interfaces/network/tcp_connected_socket.mojom.h"
 #include "net/socket/tcp_socket.h"

[mmenke, 2014/10/17 16:49:56]

Think we can just forward declare this.

 
 namespace mojo {
 
+class MojoToNetPendingBuffer;
+class NetToMojoPendingBuffer;
+
 class TCPConnectedSocketImpl : public InterfaceImpl<TCPConnectedSocket> {
  public:
   TCPConnectedSocketImpl(scoped_ptr<net::TCPSocket> socket,
                          ScopedDataPipeConsumerHandle send_stream,
                          ScopedDataPipeProducerHandle receive_stream);
   virtual ~TCPConnectedSocketImpl();
 
  private:
+  // "Receiving" in this context means reading from TCPSocket and writing to
+  // the Mojo receive_stream.
+  void ReceiveMore();

[mmenke, 2014/10/17 16:49:56]

Really could use some more method-level docs.

+  void OnReceiveStreamReady(MojoResult result);

[mmenke, 2014/10/17 16:49:56]

Include header for MojoResult?

+  void DidReceive(bool completed_synchronously, int result);
+
+  // "Writing" is reading from the Mojo send_stream and writing to the
+  // TCPSocket.
+  void SendMore();
+  void OnSendStreamReady(MojoResult result);
+  void DidSend(bool completed_asynchronously, int result);
+
   scoped_ptr<net::TCPSocket> socket_;
+
+  // The *stream handles will be null while there is an in-progress transation
+  // between net and mojo. During this time, the handle will be owned by the
+  // *PendingBuffer.
+
+  // For reading from the network and writing to Mojo pipe.
   ScopedDataPipeConsumerHandle send_stream_;
+  common::HandleWatcher receive_handle_watcher_;
+  scoped_refptr<NetToMojoPendingBuffer> pending_receive_;
+
+  // For reading from the Mojo pipe and writing to the network.
   ScopedDataPipeProducerHandle receive_stream_;
+  common::HandleWatcher send_handle_watcher_;
+  scoped_refptr<MojoToNetPendingBuffer> pending_send_;

[mmenke, 2014/10/17 16:49:56]

Need to include ref_counted.h.

+
+  base::WeakPtrFactory<TCPConnectedSocketImpl> weak_ptr_factory_;

[mmenke, 2014/10/17 16:49:56]

DISALLOW_COPY_AND_ASSIGN?

 };
 
 }  // namespace mojo
 
 #endif  // MOJO_SERVICES_NETWORK_TCP_CONNECTED_SOCKET_H_