Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 657103003: cc: Change scoped_ptr<T>() to nullptr. (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Change scoped_ptr<T>() to nullptr. R=enne Committed: https://crrev.com/968153f336dfc187cdea3267c68caf07e8be6e6f Cr-Commit-Position: refs/heads/master@{#299782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -283 lines) Patch
M cc/PRESUBMIT.py View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/animation/keyframed_animation_curve_unittest.cc View 26 chunks +68 lines, -136 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 14 chunks +28 lines, -56 lines 0 comments Download
M cc/debug/micro_benchmark_controller_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M cc/debug/unittest_only_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/debug/unittest_only_benchmark_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/input/top_controls_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M cc/layers/texture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 8 chunks +8 lines, -16 lines 0 comments Download
M cc/resources/picture_layer_tiling_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_test_common.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 11 chunks +22 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
danakj
The presubmit was missing some scoped_ptr<T>() uses so I've corrected it and removed those uses.
6 years, 2 months ago (2014-10-15 20:11:07 UTC) #1
danakj
(+156 lines, -283 lines) 127 less lines due to wrapping >_>
6 years, 2 months ago (2014-10-15 20:11:33 UTC) #2
enne (OOO)
lgtm
6 years, 2 months ago (2014-10-15 21:32:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657103003/1
6 years, 2 months ago (2014-10-15 21:33:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 22:52:28 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 22:53:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/968153f336dfc187cdea3267c68caf07e8be6e6f
Cr-Commit-Position: refs/heads/master@{#299782}

Powered by Google App Engine
This is Rietveld 408576698