Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657077: Allow snapshots built without -DANDROID to work on Android.... (Closed)

Created:
10 years, 10 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow snapshots built without -DANDROID to work on Android. Fix bug in fast code generator on ARM (can't use ip as scratch in RecordWrite). Activate normal-sized compilation cache on Android. Committed: http://code.google.com/p/v8/source/detail?r=3938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -29 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +21 lines, -17 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 10 months ago (2010-02-24 12:00:31 UTC) #1
Mads Ager (chromium)
10 years, 10 months ago (2010-02-24 12:19:30 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698