Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 657063002: Show stack traces in console for unhandled promise rejection messages. (Closed)

Created:
6 years, 2 months ago by aandrey
Modified:
6 years, 2 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Show stack traces in console for unhandled promise rejection messages. BUG=393913 R=pfeldman@chromium.org, yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183810

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixed debugger-pause-on-promise-rejection.html test #

Messages

Total messages: 10 (3 generated)
aandrey
6 years, 2 months ago (2014-10-15 11:08:52 UTC) #1
yurys
lgtm https://codereview.chromium.org/657063002/diff/1/LayoutTests/inspector/console/console-uncaught-promise.html File LayoutTests/inspector/console/console-uncaught-promise.html (right): https://codereview.chromium.org/657063002/diff/1/LayoutTests/inspector/console/console-uncaught-promise.html#newcode39 LayoutTests/inspector/console/console-uncaught-promise.html:39: setTimeout(function timeout() { style: { should go on ...
6 years, 2 months ago (2014-10-16 07:43:45 UTC) #2
aandrey
https://codereview.chromium.org/657063002/diff/1/LayoutTests/inspector/console/console-uncaught-promise.html File LayoutTests/inspector/console/console-uncaught-promise.html (right): https://codereview.chromium.org/657063002/diff/1/LayoutTests/inspector/console/console-uncaught-promise.html#newcode39 LayoutTests/inspector/console/console-uncaught-promise.html:39: setTimeout(function timeout() { On 2014/10/16 07:43:44, yurys wrote: > ...
6 years, 2 months ago (2014-10-16 09:01:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657063002/1
6 years, 2 months ago (2014-10-16 09:02:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29463)
6 years, 2 months ago (2014-10-16 10:02:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657063002/20001
6 years, 2 months ago (2014-10-16 11:19:22 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 12:45:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183810

Powered by Google App Engine
This is Rietveld 408576698