Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 657023012: Fix ServiceWorkerResourceStorageDiskTest.CleanupOnRestart flakiness on Android (Closed)

Created:
6 years, 2 months ago by Kunihiko Sakamoto
Modified:
6 years, 2 months ago
Reviewers:
falken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ServiceWorkerResourceStorageDiskTest.CleanupOnRestart flakiness on Android This test involves interactions with SimpleCache's worker thread, so we cannot guarantee task completion by simply calling RunLoop().RunUntilIdle(). TestCompletionCallback waits until the callback is called. For purging, there is no completion callback so poll is_purge_pending_ flag and call RunUntilIdle() repeatedly. BUG=387045 TEST=content_unittests --gtest-filter=ServiceWorkerResourceStorageDiskTest.* Committed: https://crrev.com/558a1c9d789332e0151c989963f6517b29455f4b Cr-Commit-Position: refs/heads/master@{#300632}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M content/browser/service_worker/service_worker_storage_unittest.cc View 4 chunks +18 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Kunihiko Sakamoto
6 years, 2 months ago (2014-10-22 01:44:14 UTC) #3
nhiroki
drive-by lgtm
6 years, 2 months ago (2014-10-22 02:16:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657023012/20001
6 years, 2 months ago (2014-10-22 02:38:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-22 04:18:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:19:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/558a1c9d789332e0151c989963f6517b29455f4b
Cr-Commit-Position: refs/heads/master@{#300632}

Powered by Google App Engine
This is Rietveld 408576698