chrome/browser/ui/chrome_pages.cc - Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | chrome/browser/ui/extensions/app_launch_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/chrome_pages.cc

diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc

index fd16b3ef192bfd9f2ee5b85f99e96d903e3b9ef0..d435af74f16fbc5ef98045cf0b696f21f65e9161 100644

--- a/chrome/browser/ui/chrome_pages.cc

+++ b/chrome/browser/ui/chrome_pages.cc

@@ -82,7 +82,19 @@ void ShowHelpImpl(Browser* browser,

extensions::ExtensionRegistry::Get(profile)->GetExtensionById(

genius_app::kGeniusAppId,

extensions::ExtensionRegistry::EVERYTHING);

- OpenApplication(AppLaunchParams(profile, extension, 0, host_desktop_type));

+ AppLaunchParams params(profile, extension, 0, host_desktop_type);

+ switch (source) {

+ case HELP_SOURCE_KEYBOARD:

+ params.source = extensions::SOURCE_KEYBOARD;

+ break;

+ case HELP_SOURCE_MENU:

+ params.source = extensions::SOURCE_SYSTEM_TRAY;

+ break;

+ case HELP_SOURCE_WEBUI:

+ params.source = extensions::SOURCE_ABOUT_PAGE;

+ break;

+ }

+ OpenApplication(params);

#else

GURL url;

switch (source) {

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | chrome/browser/ui/extensions/app_launch_params.h » ('j') | no next file with comments »