Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: apps/launcher.h

Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_load_service.cc ('k') | apps/launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/launcher.h
diff --git a/apps/launcher.h b/apps/launcher.h
index eb2d98fb265bb0bd33daa6a89aa9f63343f23c18..fa6ea1582d27dee47fee5d9b51d3a946f83c2931 100644
--- a/apps/launcher.h
+++ b/apps/launcher.h
@@ -8,6 +8,8 @@
#include <string>
#include <vector>
+#include "extensions/common/constants.h"
+
class GURL;
class Profile;
@@ -26,10 +28,12 @@ namespace apps {
// the |command_line| fields present. |extension| and |profile| must not be
// NULL. An empty |command_line| means there is no launch data. If non-empty,
// |current_directory| is used to expand any relative paths on the command line.
+// |source| is one of the enumerated values which trace how the app is launched.
void LaunchPlatformAppWithCommandLine(Profile* profile,
const extensions::Extension* extension,
const base::CommandLine& command_line,
- const base::FilePath& current_directory);
+ const base::FilePath& current_directory,
+ extensions::AppLaunchSource source);
// Launches the platform app |extension| by issuing an onLaunched event
// with the contents of |file_path| available through the launch data.
@@ -37,9 +41,11 @@ void LaunchPlatformAppWithPath(Profile* profile,
const extensions::Extension* extension,
const base::FilePath& file_path);
-// Launches the platform app |extension| with no launch data.
+// Launches the platform app |extension|. |source| tells us how the app is
+// launched.
void LaunchPlatformApp(Profile* profile,
- const extensions::Extension* extension);
+ const extensions::Extension* extension,
+ extensions::AppLaunchSource source);
// Launches the platform app |extension| with |handler_id| and the contents of
// |file_paths| available through the launch data. |handler_id| corresponds to
« no previous file with comments | « apps/app_load_service.cc ('k') | apps/launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698