chrome/browser/ui/extensions/app_launch_params.cc - Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/app_launch_params.cc

Issue 657023008: Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/app_launch_params.h ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | extensions/browser/api/app_runtime/app_runtime_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/app_launch_params.cc

diff --git a/chrome/browser/ui/extensions/app_launch_params.cc b/chrome/browser/ui/extensions/app_launch_params.cc

index a8598753a3033869a7bd0eb2e63cea039b2bf2cc..aaa66bf699cfa600fe13b082e4d95593e6b1abce 100644

--- a/chrome/browser/ui/extensions/app_launch_params.cc

+++ b/chrome/browser/ui/extensions/app_launch_params.cc

@@ -22,7 +22,9 @@ AppLaunchParams::AppLaunchParams(Profile* profile,

desktop_type(chrome::GetActiveDesktop()),

override_url(),

override_bounds(),

- command_line(CommandLine::NO_PROGRAM) {}

+ command_line(CommandLine::NO_PROGRAM),

+ source(extensions::SOURCE_UNKNOWN) {

AppLaunchParams::AppLaunchParams(Profile* profile,

const extensions::Extension* extension,

@@ -34,7 +36,8 @@ AppLaunchParams::AppLaunchParams(Profile* profile,

desktop_type(chrome::GetActiveDesktop()),

override_url(),

override_bounds(),

- command_line(CommandLine::NO_PROGRAM) {

+ command_line(CommandLine::NO_PROGRAM),

+ source(extensions::SOURCE_UNKNOWN) {

// Look up the app preference to find out the right launch container. Default

// is to launch as a regular tab.

container =

@@ -52,7 +55,8 @@ AppLaunchParams::AppLaunchParams(Profile* profile,

desktop_type(desktop_type),

override_url(),

override_bounds(),

- command_line(CommandLine::NO_PROGRAM) {

+ command_line(CommandLine::NO_PROGRAM),

+ source(extensions::SOURCE_UNKNOWN) {

if (disposition == NEW_FOREGROUND_TAB || disposition == NEW_BACKGROUND_TAB) {

container = extensions::LAUNCH_CONTAINER_TAB;

} else if (disposition == NEW_WINDOW) {