Add a new field "source" in launchData of chrome.app.runtime.onLaunched() to trace launch source.

extensions/renderer/resources/app_runtime_custom_bindings.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom binding for the chrome.app.runtime API.
 
 var binding = require('binding').Binding.create('app.runtime');
 
 var AppViewInternal =
     require('binding').Binding.create('appViewInternal').generate();
@@ skipping 29 matching lines @@
     // An onLaunched corresponding to file_handlers in the app's manifest.
     var items = [];
     var numItems = launchData.items.length;
     var itemLoaded = function(err, item) {
       if (err) {
         console.error('Error getting fileEntry, code: ' + err.code);
       } else {
         $Array.push(items, item);
       }
       if (--numItems === 0) {
-        var data = { isKioskSession: launchData.isKioskSession };
-        if (items.length !== 0) {
-          data.id = launchData.id;
-          data.items = items;
+        if (items.length == 0) {
+          delete launchData.id;
+          delete launchData.items;

[benwells, 2014/10/28 21:22:48]

Why is this changing?

[cylee1, 2014/10/29 16:40:00]

The behavior is not changed - if "items" is empty, the object passed to
onLaunched event doesn't contains this key at all - in the original
implementation.

In the original implementation, the actual object being delivered to
onLaunched() event is a totally new object  created at line 50 (in the old
version) so only contains some hard-coded fields in this function. As a result,
the new field "source" is not copied to this object. I think it should be the
opposite way - all fields other than "items" in the raw object should be passed
to onLaunched event by default.

[benwells, 2014/10/30 06:04:28]

I think I see what you're trying to do. I'd prefer you to use the previous
method. What your doing here I think is dangerous as it will be easier for
implementation details / things we want hidden to leak out to extensions.

I'm not sure though ... I need to think about it. Either way, I'd prefer  to
separate that change out. I don't think it is related to the change you're
making. E.g. if there was a problem with passing the object through I'd prefer
that to be a separate, revertable-by-itself change.

+        } else {
+          launchData.items = items;
         }
-        dispatch([data]);
+        dispatch([launchData]);
       }
     };
     $Array.forEach(launchData.items, function(item) {
-      var fs = GetIsolatedFileSystem(item.fileSystemId);
-      fs.root.getFile(item.baseName, {}, function(fileEntry) {
-        entryIdManager.registerEntry(item.entryId, fileEntry);
-        itemLoaded(null, { entry: fileEntry, type: item.mimeType });
+      var rawEntry = item.rawEntry;
+      delete item.rawEntry;
+      var fs = GetIsolatedFileSystem(rawEntry.fileSystemId);
+      fs.root.getFile(rawEntry.baseName, {}, function(fileEntry) {
+        entryIdManager.registerEntry(rawEntry.entryId, fileEntry);
+        item.entry = fileEntry;

[benwells, 2014/10/28 21:22:48]

Again, why is this changing?

[cylee1, 2014/10/29 16:40:00]

Explained above. It's only a re-implementation and nothing is changed in effect.
The field "item.mimeType" is already set in the raw object so no need to set it
again here.

+        itemLoaded(null, item);
       }, function(fileError) {
         itemLoaded(fileError);
       });
     });
   } else {
     // Default case. This currently covers an onLaunched corresponding to
     // url_handlers in the app's manifest.
     dispatch([launchData]);
   }
 });
 
 exports.binding = binding.generate();