Chromium Code Reviews Chromium Code Reviews
Issue
657023006:
GC::drawConvexPolygon() & friends cleanup (Closed)
DescriptionGC::drawConvexPolygon() & friends cleanup
Assorted tweaks:
* Both drawConvexPolygon() clients (ObjectPainter::drawSolidBoxSide
& RenderThemeChromiumMac::paintMenuListButton) turn off stroking,
so we're always in fill-only mode. Update the method to reflect
this limited scope, and stop mutating the global stroke style.
* Take an explicit color param to avoid changing (and leaking in
the case of drawSolidBoxSide) the global fill color.
(because of the above, drawSolidBoxSides no longer dirties the GC paint
state in the common case => reduced pressure for committing deferred
paint saves).
* All drawConvexPolygon & clipConvexPolygon callers except
RenderThemeChromiumMac pass in four points (quads), and per comments
in setPathFromConvexPoints we don't assume convexity in this common
case => update the method names to reflect this reality.
R=schenney@chromium.org,senorblanco@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183772
Patch Set 1 #Patch Set 2 : speculative RenderThemeChromiumMac fix #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
