Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 65683003: Create WindowAndroid in WebView. (Closed)

Created:
7 years, 1 month ago by michaelbai
Modified:
7 years, 1 month ago
Reviewers:
joth
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Create WindowAndroid in WebView. BUG=308460 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233873

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : Sync #

Patch Set 4 : Sync and fix conflicts #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 3 4 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
michaelbai
https://codereview.chromium.org/65683003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/65683003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode510 android_webview/java/src/org/chromium/android_webview/AwContents.java:510: new ActivityWindowAndroid((Activity)context) : new WindowAndroid(context), It looks weird ContentView ...
7 years, 1 month ago (2013-11-07 23:54:00 UTC) #1
michaelbai
I have a downstream bug relies on this, PTAL https://b.corp.google.com/issue?id=11553674
7 years, 1 month ago (2013-11-07 23:56:37 UTC) #2
joth
lgtm
7 years, 1 month ago (2013-11-08 00:38:40 UTC) #3
joth
https://codereview.chromium.org/65683003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/65683003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode510 android_webview/java/src/org/chromium/android_webview/AwContents.java:510: new ActivityWindowAndroid((Activity)context) : new WindowAndroid(context), On 2013/11/07 23:54:00, michaelbai ...
7 years, 1 month ago (2013-11-08 00:40:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/65683003/80001
7 years, 1 month ago (2013-11-08 06:14:49 UTC) #5
commit-bot: I haz the power
Failed to apply patch for android_webview/java/src/org/chromium/android_webview/AwContents.java: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-08 06:14:52 UTC) #6
michaelbai
https://codereview.chromium.org/65683003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/65683003/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode510 android_webview/java/src/org/chromium/android_webview/AwContents.java:510: new ActivityWindowAndroid((Activity)context) : new WindowAndroid(context), On 2013/11/08 00:40:20, joth ...
7 years, 1 month ago (2013-11-08 06:32:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/65683003/120001
7 years, 1 month ago (2013-11-08 06:32:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/65683003/300001
7 years, 1 month ago (2013-11-08 06:54:07 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 11:42:51 UTC) #10
Message was sent while issue was closed.
Change committed as 233873

Powered by Google App Engine
This is Rietveld 408576698