Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 656803002: [Android] Don't let chromium_commands modify all_dependent_settings via java.gypi (Closed)

Created:
6 years, 2 months ago by jbudorick
Modified:
6 years, 2 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't let chromium_commands modify all_dependent_settings via java.gypi BUG=423025 Committed: https://crrev.com/e1adb7edbdfa6a76da39a841c8a150bc54cb78fe Cr-Commit-Position: refs/heads/master@{#300086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M build/android/pylib/device/commands/commands.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/java.gypi View 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
Not sure that this is the best way to have chromium_commands use java.gypi but avoid ...
6 years, 2 months ago (2014-10-14 12:20:27 UTC) #2
cjhopman
On 2014/10/14 12:20:27, jbudorick wrote: > Not sure that this is the best way to ...
6 years, 2 months ago (2014-10-16 18:11:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656803002/1
6 years, 2 months ago (2014-10-17 09:24:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 10:35:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 10:36:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1adb7edbdfa6a76da39a841c8a150bc54cb78fe
Cr-Commit-Position: refs/heads/master@{#300086}

Powered by Google App Engine
This is Rietveld 408576698