Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 656793004: Use RunLoop, but do not call RunUntilIdle() multiple times (Closed)

Created:
6 years, 2 months ago by Takashi Toyoshima
Modified:
6 years, 2 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use RunLoop, but do not call RunUntilIdle() multiple times In unit tests for MidiManager, RunLoop was used, and is used to wait a posted task finished. But, RunUntilIdle() can not be called multiple times. To avoid this restriction, we can just create new instance again for another iteration. TEST=media_unittests Committed: https://crrev.com/a42e46ee2110aeebb70d9787a0aa05997ec9c67a Cr-Commit-Position: refs/heads/master@{#300240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M media/midi/midi_manager_unittest.cc View 1 chunk +4 lines, -17 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Takashi Toyoshima
RunLoop.RunUntilIdle() is called multiple times in another test, and this is potential issue. I didn't ...
6 years, 2 months ago (2014-10-18 15:29:47 UTC) #2
yhirano
lgtm
6 years, 2 months ago (2014-10-20 02:29:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656793004/1
6 years, 2 months ago (2014-10-20 02:34:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 09:37:18 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 09:38:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a42e46ee2110aeebb70d9787a0aa05997ec9c67a
Cr-Commit-Position: refs/heads/master@{#300240}

Powered by Google App Engine
This is Rietveld 408576698