Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.h

Issue 656733002: Fix filesystem.retainEntry API to handle non-native directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed windows build. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/file_system/file_system_api.h
diff --git a/chrome/browser/extensions/api/file_system/file_system_api.h b/chrome/browser/extensions/api/file_system/file_system_api.h
index b2cb1add2961345eca714b20e9013e8753170565..62bfa52753e6e71037f80f03764b3ff64fac3e1f 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api.h
+++ b/chrome/browser/extensions/api/file_system/file_system_api.h
@@ -182,16 +182,12 @@ class FileSystemRetainEntryFunction : public ChromeAsyncExtensionFunction {
private:
// Retains the file entry referenced by |entry_id| in apps::SavedFilesService.
- // |entry_id| must refer to an entry in an isolated file system.
- void RetainFileEntry(const std::string& entry_id);
-
- void SetIsDirectoryOnFileThread();
-
- // Whether the file being retained is a directory.
- bool is_directory_;
-
- // The path to the file to retain.
- base::FilePath path_;
+ // |entry_id| must refer to an entry in an isolated file system. |path| is a
+ // path of the entry. |file_info| is base::File::Info of the entry if it can
+ // be obtained.
+ void RetainFileEntry(const std::string& entry_id,
+ const base::FilePath& path,
+ scoped_ptr<base::File::Info> file_info);
};
class FileSystemIsRestorableFunction : public ChromeSyncExtensionFunction {

Powered by Google App Engine
This is Rietveld 408576698