chrome/browser/extensions/api/file_system/file_system_api.h - Issue 656733002: Fix filesystem.retainEntry API to handle non-native directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.h

Issue 656733002: Fix filesystem.retainEntry API to handle non-native directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc ('k') | chrome/browser/extensions/api/file_system/file_system_api.cc » ('j') | chrome/browser/extensions/api/file_system/file_system_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_system/file_system_api.h

diff --git a/chrome/browser/extensions/api/file_system/file_system_api.h b/chrome/browser/extensions/api/file_system/file_system_api.h

index b2cb1add2961345eca714b20e9013e8753170565..0c011f307cdb1843123b42e5e51c32c9c9ea359b 100644

--- a/chrome/browser/extensions/api/file_system/file_system_api.h

+++ b/chrome/browser/extensions/api/file_system/file_system_api.h

@@ -185,7 +185,9 @@ class FileSystemRetainEntryFunction : public ChromeAsyncExtensionFunction {

// |entry_id| must refer to an entry in an isolated file system.

void RetainFileEntry(const std::string& entry_id);

- void SetIsDirectoryOnFileThread();

+ void SetIsDirectoryOnIOThread(const std::string& entry_id,

mtomasz 2014/10/14 06:08:50 nit: Please add a comment.

hirono 2014/10/14 09:22:10 I removed the method.

+ base::File::Error result,

+ const base::File::Info& file_info);

// Whether the file being retained is a directory.

bool is_directory_;