Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: Source/core/html/HTMLEmbedElement.cpp

Issue 656723005: Use C++11 features in core/html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use meaningful names Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 m_imageLoader->updateFromElement(ImageLoader::UpdateIgnorePreviousEr ror); 106 m_imageLoader->updateFromElement(ImageLoader::UpdateIgnorePreviousEr ror);
107 } 107 }
108 } else { 108 } else {
109 HTMLPlugInElement::parseAttribute(name, value); 109 HTMLPlugInElement::parseAttribute(name, value);
110 } 110 }
111 } 111 }
112 112
113 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St ring>& paramValues) 113 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St ring>& paramValues)
114 { 114 {
115 AttributeCollection attributes = this->attributes(); 115 AttributeCollection attributes = this->attributes();
116 AttributeCollection::iterator end = attributes.end(); 116 for (const auto& attribute : attributes) {
117 for (AttributeCollection::iterator it = attributes.begin(); it != end; ++it) { 117 paramNames.append(attribute.localName().string());
118 paramNames.append(it->localName().string()); 118 paramValues.append(attribute.value().string());
119 paramValues.append(it->value().string());
120 } 119 }
121 } 120 }
122 121
123 // FIXME: This should be unified with HTMLObjectElement::updateWidget and 122 // FIXME: This should be unified with HTMLObjectElement::updateWidget and
124 // moved down into HTMLPluginElement.cpp 123 // moved down into HTMLPluginElement.cpp
125 void HTMLEmbedElement::updateWidgetInternal() 124 void HTMLEmbedElement::updateWidgetInternal()
126 { 125 {
127 ASSERT(!renderEmbeddedObject()->showsUnavailablePluginIndicator()); 126 ASSERT(!renderEmbeddedObject()->showsUnavailablePluginIndicator());
128 ASSERT(needsWidgetUpdate()); 127 ASSERT(needsWidgetUpdate());
129 setNeedsWidgetUpdate(false); 128 setNeedsWidgetUpdate(false);
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 { 190 {
192 // http://www.whatwg.org/specs/web-apps/current-work/#exposed 191 // http://www.whatwg.org/specs/web-apps/current-work/#exposed
193 for (HTMLObjectElement* object = Traversal<HTMLObjectElement>::firstAncestor (*this); object; object = Traversal<HTMLObjectElement>::firstAncestor(*object)) { 192 for (HTMLObjectElement* object = Traversal<HTMLObjectElement>::firstAncestor (*this); object; object = Traversal<HTMLObjectElement>::firstAncestor(*object)) {
194 if (object->isExposed()) 193 if (object->isExposed())
195 return false; 194 return false;
196 } 195 }
197 return true; 196 return true;
198 } 197 }
199 198
200 } 199 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698