Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 656723005: Use C++11 features in core/html (Closed)

Created:
6 years, 2 months ago by riju_
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, Yoav Weiss, philipj_slow, Rik, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, aandrey+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Improves code readability in in core/html by Using C++11 range-based loop. Using ">>" instead of "> >" in templates. Using nullptr instead of 0. BUG=none TEST=no layout test failures Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184834

Patch Set 1 #

Patch Set 2 : Use meaningful names #

Total comments: 5

Patch Set 3 : rebase #

Patch Set 4 : use nullptr #

Total comments: 13

Patch Set 5 : mike's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -469 lines) Patch
M Source/core/html/CollectionIndexCache.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/FormAssociatedElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAreaElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 2 3 6 chunks +10 lines, -13 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 2 3 4 7 chunks +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 1 2 3 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 9 chunks +15 lines, -18 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 1 2 3 4 chunks +8 lines, -9 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 3 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLegendElement.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 3 10 chunks +18 lines, -21 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 31 chunks +33 lines, -33 lines 0 comments Download
M Source/core/html/HTMLShadowElement.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LinkRelAttribute.cpp View 1 2 1 chunk +13 lines, -14 lines 0 comments Download
M Source/core/html/MediaController.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaFragmentURIParser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/PublicURLManager.cpp View 1 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/URLRegistry.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 17 chunks +17 lines, -17 lines 0 comments Download
M Source/core/html/canvas/HitRegion.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/HitRegion.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLContextGroup.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 1 2 3 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/canvas/WebGLObject.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 2 3 10 chunks +17 lines, -17 lines 0 comments Download
M Source/core/html/canvas/WebGLSharedObject.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLTexture.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FormController.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FormController.cpp View 1 2 3 4 6 chunks +20 lines, -20 lines 0 comments Download
M Source/core/html/forms/HiddenInputType.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/RadioButtonGroupScope.cpp View 1 2 3 5 chunks +7 lines, -12 lines 0 comments Download
M Source/core/html/imports/HTMLImport.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImport.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportChild.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportLoader.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportTreeRoot.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportTreeRoot.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportsController.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportsController.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/AtomicHTMLToken.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/CompactHTMLToken.cpp View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/parser/HTMLElementStack.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/parser/HTMLFormattingElementList.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLFormattingElementList.cpp View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.cpp View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLSrcsetParser.cpp View 1 2 3 4 6 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCueList.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackCueList.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackList.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TrackListBase.h View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTRegionList.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTRegionList.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/track/vtt/VTTScanner.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
riju_
6 years, 2 months ago (2014-10-20 17:55:43 UTC) #3
Mike West
Would you mind going through the callsites here, and making a decision about whether or ...
6 years, 2 months ago (2014-10-20 18:12:44 UTC) #4
sof
ps#2 is fine wrt Oilpan, but would echo feedback already given wrt a balanced use ...
6 years, 2 months ago (2014-10-21 09:58:43 UTC) #5
Mike West
Happy to re-review this once you fix the compilation error.
6 years, 2 months ago (2014-10-23 07:50:34 UTC) #8
Mike West
This was painful to slog through. Please, please, please split up CLs like this one. ...
6 years, 1 month ago (2014-11-04 15:25:53 UTC) #15
riju_
Thanks Mike for your time, I had a few more changes to make, but I ...
6 years, 1 month ago (2014-11-04 17:50:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656723005/260001
6 years, 1 month ago (2014-11-04 18:05:03 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 19:05:25 UTC) #19
Message was sent while issue was closed. 
Committed patchset #5 (id:260001) as 184834

Powered by Google App Engine
This is Rietveld 408576698