Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 656723002: [Win] Update HWND max size if either width or height is set. (Closed)

Created:
6 years, 2 months ago by jackhou1
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Win] Update HWND max size if either width or height is set. gfx::Size::IsEmpty() is equivalent to (width() == 0 || height() == 0), so the max size is not correctly set when only one dimension is provided. BUG=0 Committed: https://crrev.com/1a13cda009929d61b4cc859ddb4f510307b7cad6 Cr-Commit-Position: refs/heads/master@{#299625}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jackhou1
sky, could you take a look?
6 years, 2 months ago (2014-10-14 04:45:40 UTC) #2
sky
LGTM https://codereview.chromium.org/656723002/diff/1/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/656723002/diff/1/ui/views/win/hwnd_message_handler.cc#newcode1434 ui/views/win/hwnd_message_handler.cc:1434: if (max_window_size.width()) { nit: no {} here and ...
6 years, 2 months ago (2014-10-14 19:20:11 UTC) #3
jackhou1
https://codereview.chromium.org/656723002/diff/1/ui/views/win/hwnd_message_handler.cc File ui/views/win/hwnd_message_handler.cc (right): https://codereview.chromium.org/656723002/diff/1/ui/views/win/hwnd_message_handler.cc#newcode1434 ui/views/win/hwnd_message_handler.cc:1434: if (max_window_size.width()) { On 2014/10/14 19:20:10, sky wrote: > ...
6 years, 2 months ago (2014-10-14 23:49:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656723002/20001
6 years, 2 months ago (2014-10-14 23:50:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 02:17:38 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 02:18:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a13cda009929d61b4cc859ddb4f510307b7cad6
Cr-Commit-Position: refs/heads/master@{#299625}

Powered by Google App Engine
This is Rietveld 408576698