minidump/minidump_string_writer_test.cc - Issue 656703002: Convert NULL to nullptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_string_writer_test.cc

Issue 656703002: Convert NULL to nullptr (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Fix 80-column violations Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_string_writer_test.cc

diff --git a/minidump/minidump_string_writer_test.cc b/minidump/minidump_string_writer_test.cc

index 9e684cef85f0dcc9b0ed2d692292480ac14d5914..c4eccd2d7a1a81e2573e2d8c3920b6c9082a1f6a 100644

--- a/minidump/minidump_string_writer_test.cc

+++ b/minidump/minidump_string_writer_test.cc

@@ -133,7 +133,7 @@ TEST(MinidumpStringWriter, ConvertInvalidUTF8ToUTF16) {

size_t out_units =

minidump_string->Length / sizeof(minidump_string->Buffer[0]);

EXPECT_EQ(0, minidump_string->Buffer[out_units]);

- EXPECT_NE(reinterpret_cast<char16*>(NULL),

+ EXPECT_NE(nullptr,

base::c16memchr(minidump_string->Buffer, 0xfffd, out_units));

}

« no previous file with comments | « minidump/minidump_module_writer_test.cc ('k') | minidump/minidump_thread_writer.h » ('j') | no next file with comments »