Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp - Issue 656693002: Don't count UseCounters in private scripts

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

Issue 656693002: Don't count UseCounters in private scripts (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

index 1e8a7947dba70291981b83aeeda5cd9759ef63cb..e9a3927980f4b995500e6857bf737c9ec849efbd 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

@@ -193,7 +193,7 @@ static void deprecatedInitializedByEventConstructorReadonlyStringAttributeAttrib

static void deprecatedInitializedByEventConstructorReadonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

{

TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

+ UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

TestInterfaceEventConstructorV8Internal::deprecatedInitializedByEventConstructorReadonlyStringAttributeAttributeGetter(info);

TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

@@ -222,7 +222,7 @@ static void deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAt

static void deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

{

TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

+ UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

TestInterfaceEventConstructorV8Internal::deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttributeAttributeGetter(info);

TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");

}

@@ -301,7 +301,7 @@ bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit&

return false;

if (DictionaryHelper::convert(options, conversionContext.setConversionType("DOMString", false), "deprecatedInitializedByEventConstructorReadonlyStringAttribute", eventInit.deprecatedInitializedByEventConstructorReadonlyStringAttribute)) {

if (options.hasProperty("deprecatedInitializedByEventConstructorReadonlyStringAttribute"))

- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

+ UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

} else {

return false;

}

@@ -309,7 +309,7 @@ bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit&

return false;

if (DictionaryHelper::convert(options, conversionContext.setConversionType("DOMString", false), "deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttribute", eventInit.deprecatedImplementedAsName)) {

if (options.hasProperty("deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttribute"))

- UseCounter::countDeprecation(callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

+ UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::initializedByEventConstructorReadonlyStringAttribute);

} else {

return false;

}