Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp - Issue 656693002: Don't count UseCounters in private scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 656693002: Don't count UseCounters in private scripts (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

index 16f6044a9c2a7ccd277e375e03f6671b94745fbf..f973a79c4213046eb16d405e38986aa9b4482c9a 100644

--- a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

@@ -98,7 +98,7 @@ void V8HTMLAllCollection::legacyCallCustom(const v8::FunctionCallbackInfo<v8::Va

HTMLAllCollection* impl = V8HTMLAllCollection::toImpl(info.Holder());

Node& ownerNode = impl->ownerNode();

- UseCounter::count(ownerNode.document(), UseCounter::DocumentAllLegacyCall);

+ UseCounter::countIfNotPrivateScript(info.GetIsolate(), ownerNode.document(), UseCounter::DocumentAllLegacyCall);

if (info.Length() == 1) {

v8SetReturnValue(info, getItem(impl, info[0], info));