Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 656683009: Clean up forward declarations in Source/core/events (Closed)

Created:
6 years, 2 months ago by rwlbuis
Modified:
6 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, nessy, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, dglazkov+blink, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/events These forward references are not needed anymore. After this patch, Source/core/events has no unneeded forward references any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M Source/core/events/DOMWindowEventQueue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/Event.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventDispatchMediator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventListener.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventTarget.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/events/FocusEvent.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/KeyboardEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrackCue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 2 months ago (2014-10-17 21:31:47 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-18 01:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656683009/1
6 years, 2 months ago (2014-10-18 01:27:25 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 02:39:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183935

Powered by Google App Engine
This is Rietveld 408576698