Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 656683005: Use parseHTMLInteger for parsing minlength and maxlength in <textarea> (Closed)

Created:
6 years, 2 months ago by Bartek Nowierski
Modified:
6 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, keishi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use parseHTMLInteger for parsing minlength and maxlength in <textarea> BUG=390485 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184250

Patch Set 1 #

Patch Set 2 : Pull #

Patch Set 3 : Pull #

Patch Set 4 : Pull #

Patch Set 5 : Add layout tests that check for leading non-ASCII whitespaces in min/maxlength attribute #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M LayoutTests/fast/forms/textarea-maxlength.html View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/textarea-maxlength-expected.txt View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/textarea-minlength.html View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/textarea-minlength-expected.txt View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Bartek Nowierski
6 years, 2 months ago (2014-10-22 08:20:00 UTC) #2
tkent
Please add tests. I think differences are allowed whitespace characters. toInt() allows leading non-ASCII whitespace ...
6 years, 2 months ago (2014-10-22 08:32:17 UTC) #3
Bartek Nowierski
Done.
6 years, 2 months ago (2014-10-23 08:41:16 UTC) #4
tkent
lgtm. Thank you!
6 years, 2 months ago (2014-10-23 08:43:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656683005/80001
6 years, 2 months ago (2014-10-23 08:44:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/14688)
6 years, 2 months ago (2014-10-23 08:59:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656683005/80001
6 years, 2 months ago (2014-10-23 09:30:27 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 09:46:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 184250

Powered by Google App Engine
This is Rietveld 408576698