Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 656683004: Add conversion rule of WebAXRoleBlockquote (Closed)

Created:
6 years, 2 months ago by je_julie(Not used)
Modified:
6 years, 1 month ago
Reviewers:
*dmazzoni, Mike West
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add conversion rule of WebAXRoleBlockquote The related to CL: https://codereview.chromium.org/654303004/ BUG=347854 TBR=rockot Committed: https://crrev.com/f3370050c1c1ee1e350d17dea653b3969779bbad Cr-Commit-Position: refs/heads/master@{#301272}

Patch Set 1 #

Patch Set 2 : Add TC results #

Patch Set 3 : Rebased wihtout actual change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/blockquote.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/blockquote-expected-android.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/blockquote-expected-mac.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/blockquote-expected-win.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
je_julie(Not used)
Hi Dominic and Mike, It's for AX handling blockquote tag. The implementation at Blink is ...
6 years, 2 months ago (2014-10-18 14:05:20 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-20 16:36:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656683004/20001
6 years, 1 month ago (2014-10-24 15:17:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73193) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/27375) android_arm64_dbg_recipe ...
6 years, 1 month ago (2014-10-24 15:22:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656683004/40001
6 years, 1 month ago (2014-10-25 02:00:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20052)
6 years, 1 month ago (2014-10-25 02:10:12 UTC) #12
je_julie(Not used)
+TBR:rockot because the IDL change is trivial.
6 years, 1 month ago (2014-10-25 02:55:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656683004/40001
6 years, 1 month ago (2014-10-25 02:56:30 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-25 02:59:39 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 03:00:22 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f3370050c1c1ee1e350d17dea653b3969779bbad
Cr-Commit-Position: refs/heads/master@{#301272}

Powered by Google App Engine
This is Rietveld 408576698