Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: test/mjsunit/array-unshift.js

Issue 656683003: Revert "Remove SmartMove, bringing Array methods further into spec compliance" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/array-shift2.js ('k') | test/mjsunit/bugs/bug-2615.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 assertEquals(array[5], array_proto[5]); 183 assertEquals(array[5], array_proto[5]);
184 assertFalse(array.hasOwnProperty(5)); 184 assertFalse(array.hasOwnProperty(5));
185 185
186 assertEquals(array[3], array_proto[3]); 186 assertEquals(array[3], array_proto[3]);
187 assertFalse(array.hasOwnProperty(3)); 187 assertFalse(array.hasOwnProperty(3));
188 188
189 assertEquals(array[7], array_proto[7]); 189 assertEquals(array[7], array_proto[7]);
190 assertFalse(array.hasOwnProperty(7)); 190 assertFalse(array.hasOwnProperty(7));
191 })(); 191 })();
192 192
193 /*
194 // Check the behaviour when approaching maximal values for length. 193 // Check the behaviour when approaching maximal values for length.
195 (function() { 194 (function() {
196 for (var i = 0; i < 7; i++) { 195 for (var i = 0; i < 7; i++) {
197 try { 196 try {
198 new Array(Math.pow(2, 32) - 3).unshift(1, 2, 3, 4, 5); 197 new Array(Math.pow(2, 32) - 3).unshift(1, 2, 3, 4, 5);
199 throw 'Should have thrown RangeError'; 198 throw 'Should have thrown RangeError';
200 } catch (e) { 199 } catch (e) {
201 assertTrue(e instanceof RangeError); 200 assertTrue(e instanceof RangeError);
202 } 201 }
203 202
204 // Check smi boundary 203 // Check smi boundary
205 var bigNum = (1 << 30) - 3; 204 var bigNum = (1 << 30) - 3;
206 assertEquals(bigNum + 7, new Array(bigNum).unshift(1, 2, 3, 4, 5, 6, 7)); 205 assertEquals(bigNum + 7, new Array(bigNum).unshift(1, 2, 3, 4, 5, 6, 7));
207 } 206 }
208 })(); 207 })();
209 */
210 208
211 (function() { 209 (function() {
212 for (var i = 0; i < 7; i++) { 210 for (var i = 0; i < 7; i++) {
213 var a = [6, 7, 8, 9]; 211 var a = [6, 7, 8, 9];
214 a.unshift(1, 2, 3, 4, 5); 212 a.unshift(1, 2, 3, 4, 5);
215 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a); 213 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a);
216 } 214 }
217 })(); 215 })();
218 216
219 // Check that non-enumerable elements are treated appropriately 217 // Check that non-enumerable elements are treated appropriately
220 (function() { 218 (function() {
221 var array = [2, 3]; 219 var array = [2, 3];
222 Object.defineProperty(array, '1', {enumerable: false}); 220 Object.defineProperty(array, '1', {enumerable: false});
223 array.unshift(1) 221 array.unshift(1)
224 assertEquals([1, 2, 3], array); 222 assertEquals([1, 2, 3], array);
225 223
226 array = [2]; 224 array = [2];
227 array.length = 2; 225 array.length = 2;
228 array.__proto__[1] = 3; 226 array.__proto__[1] = 3;
229 Object.defineProperty(array.__proto__, '1', {enumerable: false}); 227 Object.defineProperty(array.__proto__, '1', {enumerable: false});
230 array.unshift(1); 228 array.unshift(1);
231 assertEquals([1, 2, 3], array); 229 assertEquals([1, 2, 3], array);
232 })(); 230 })();
OLDNEW
« no previous file with comments | « test/mjsunit/array-shift2.js ('k') | test/mjsunit/bugs/bug-2615.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698