Issue 656683003: Revert "Remove SmartMove, bringing Array methods further into spec compliance"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 656683003: Revert "Remove SmartMove, bringing Array methods further into spec compliance" (Closed)

Created:
6 years, 2 months ago by adamk

Modified:
6 years, 2 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Remove SmartMove, bringing Array methods further into spec compliance" This reverts https://code.google.com/p/v8/source/detail?r=24647 It caused test failures in Array methods in Linux64 OptimizeForSize. BUG=v8:2615 TBR=verwaest@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24648

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -130 lines)			Patch
M	src/array.js	View	5 chunks	+68 lines, -7 lines	0 comments	Download
M	test/mjsunit/array-functions-prototype-misc.js	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	test/mjsunit/array-natives-elements.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/array-shift2.js	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/array-unshift.js	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	test/mjsunit/bugs/bug-2615.js	View	1 chunk	+84 lines, -0 lines	0 comments	Download
D	test/mjsunit/regress/regress-2615.js	View	1 chunk	+0 lines, -112 lines	0 comments	Download
M	test/mjsunit/regress/regress-crbug-412319.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

adamk

6 years, 2 months ago (2014-10-15 23:53:08 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24648 (tree was closed).