Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 656673003: Docserver: Cache the samples. (Closed)

Created:
6 years, 2 months ago by not at google - send to devlin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Docserver: Cache the samples in the API reference documentation. This is probably the main source of Docserver slowness. Doing so also leads to some nice cleanups, like removing the odd samples getter and making samples resolution asynchronous. R=rockot@chromium.org BUG=415309 Committed: https://crrev.com/81ab7b017ba2fa14ec5b962d173bf39c4151b10a Cr-Commit-Position: refs/heads/master@{#299973}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -140 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 1 4 chunks +15 lines, -22 lines 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/jsc_view.py View 1 5 chunks +78 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/server2/jsc_view_test.py View 1 9 chunks +63 lines, -45 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_data_source.py View 1 chunk +1 line, -47 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_model.py View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_model_test.py View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
not at google - send to devlin
6 years, 2 months ago (2014-10-15 23:37:21 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-16 19:09:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656673003/20001
6 years, 2 months ago (2014-10-16 20:00:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 20:55:11 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 20:56:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81ab7b017ba2fa14ec5b962d173bf39c4151b10a
Cr-Commit-Position: refs/heads/master@{#299973}

Powered by Google App Engine
This is Rietveld 408576698