Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issue 656663002: Fix type truncation warnings in YUV-related code. (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix type truncation warnings in YUV-related code. BUG=81439 TEST=none Committed: https://crrev.com/b9944315f9b1888d59d04072e1d72ddfce600185 Cr-Commit-Position: refs/heads/master@{#299409}

Patch Set 1 #

Patch Set 2 : Remove erroneous pragma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M media/base/simd/convert_rgb_to_yuv_sse2.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M media/base/simd/filter_yuv.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/simd/filter_yuv_c.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/simd/filter_yuv_sse2.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/yuv_convert.cc View 5 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Peter Kasting
6 years, 2 months ago (2014-10-13 23:33:01 UTC) #2
DaleCurtis
lgtm, presumably you're not using the _t versions for consistency with surrounding code?
6 years, 2 months ago (2014-10-13 23:36:18 UTC) #3
Peter Kasting
On 2014/10/13 23:36:18, DaleCurtis wrote: > lgtm, presumably you're not using the _t versions for ...
6 years, 2 months ago (2014-10-13 23:42:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656663002/20001
6 years, 2 months ago (2014-10-13 23:44:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/58058) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/62768)
6 years, 2 months ago (2014-10-14 00:24:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656663002/20001
6 years, 2 months ago (2014-10-14 00:29:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-14 00:53:37 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:54:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9944315f9b1888d59d04072e1d72ddfce600185
Cr-Commit-Position: refs/heads/master@{#299409}

Powered by Google App Engine
This is Rietveld 408576698