Update fetch to support more flexible refspecs

Update fetch to support more flexible refspecs

R=machenbach@chromium.org
BUG=415464
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292588

[Michael Achenbach, 2014-10-22 09:46:28]

https://codereview.chromium.org/656623003/diff/1/fetch
File fetch (left):

https://codereview.chromium.org/656623003/diff/1/fetch#oldcode7
fetch:7: 
Rubber stamp on this.

https://codereview.chromium.org/656623003/diff/1/recipes/blink.py
File recipes/blink.py (left):

https://codereview.chromium.org/656623003/diff/1/recipes/blink.py#oldcode20
recipes/blink.py:20: 'svn_url': 'svn://svn.chromium.org/blink/trunk',
So, auto-svn has a mapping from git to svn urls?

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py
File recipes/depot_tools.py (left):

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py#oldco...
recipes/depot_tools.py:31: if props.get('submodule_git_svn_spec'):
Rubber stamp on this.

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py
File recipes/depot_tools.py (right):

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py#newco...
recipes/depot_tools.py:21: 'deps_file'   : 'DEPS',
Is this fixing a bug? Is that DEPS file git or svn?

[agable, 2014-10-22 10:03:33]

https://codereview.chromium.org/656623003/diff/1/fetch
File fetch (left):

https://codereview.chromium.org/656623003/diff/1/fetch#oldcode7
fetch:7: 
On 2014/10/22 09:46:28, Michael Achenbach wrote:
> Rubber stamp on this.

Yeah, this code is supposed to run when you run 'gclient', not other utilities
like 'fetch'.

https://codereview.chromium.org/656623003/diff/1/recipes/blink.py
File recipes/blink.py (left):

https://codereview.chromium.org/656623003/diff/1/recipes/blink.py#oldcode20
recipes/blink.py:20: 'svn_url': 'svn://svn.chromium.org/blink/trunk',
On 2014/10/22 09:46:28, Michael Achenbach wrote:
> So, auto-svn has a mapping from git to svn urls?

auto-svn determines the mapping directly from the git-svn-id footer. That's why
it's "auto": no need for any configuration stored anywhere.

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py
File recipes/depot_tools.py (left):

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py#oldco...
recipes/depot_tools.py:31: if props.get('submodule_git_svn_spec'):
On 2014/10/22 09:46:28, Michael Achenbach wrote:
> Rubber stamp on this.

Just some cleanup of dead (actually never alive) code.

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py
File recipes/depot_tools.py (right):

https://codereview.chromium.org/656623003/diff/1/recipes/depot_tools.py#newco...
recipes/depot_tools.py:21: 'deps_file'   : 'DEPS',
On 2014/10/22 09:46:28, Michael Achenbach wrote:
> Is this fixing a bug? Is that DEPS file git or svn?

depot_tools doesn't have a DEPS file at all, in fact. That's by design. But
solutions have to have a deps_file, so this is "less incorrect".

[Michael Achenbach, 2014-10-22 10:06:19]

lgtm

[agable, 2014-10-22 10:35:37]

Committed patchset #1 (id:1) manually as 292588.