Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 656533003: Special handling for inline caches in code serializer. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Special handling for inline caches in code serializer. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24722

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -37 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/serialize.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/serialize.cc View 1 9 chunks +65 lines, -25 lines 0 comments Download
M test/mjsunit/serialize-ic.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-17 09:47:16 UTC) #1
mvstanton
LGTM, one nit. --Michael https://codereview.chromium.org/656533003/diff/1/src/execution.cc File src/execution.cc (right): https://codereview.chromium.org/656533003/diff/1/src/execution.cc#newcode42 src/execution.cc:42: if (script->IsScript()) Script::cast(script)->name()->ShortPrint(); Whew, much ...
6 years, 2 months ago (2014-10-17 16:16:38 UTC) #2
Yang
6 years, 2 months ago (2014-10-20 08:46:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698