Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 656533002: Rebaseline inspector/layers/layer-canvas-log.html for SkRecord (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rebaseline inspector/layers/layer-canvas-log.html for SkRecord - SkRecord stores all matrix-changes as setMatrix. This accounts for translate -> setMatrix in #6. - SkRecordNoopSaveLayerDrawRestore turned the saveLayer/drawRect/restore in #9-#11 into a single drawRect. This test is suppressed by skia/skia_test_expectations.txt, so I will have to remove that in a follow-up CL. BUG=408985 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -38 lines) Patch
M LayoutTests/inspector/layers/layer-canvas-log-expected.txt View 5 chunks +22 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein
6 years, 2 months ago (2014-10-13 20:11:13 UTC) #2
robertphillips
lgtm
6 years, 2 months ago (2014-10-14 12:16:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656533002/1
6 years, 2 months ago (2014-10-14 12:18:24 UTC) #6
blink-reviews
Ping? This one needs to land first. On Mon, Oct 13, 2014, 4:11 PM null ...
6 years, 2 months ago (2014-10-14 12:37:04 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 13:21:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183672

Powered by Google App Engine
This is Rietveld 408576698