Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 656523002: fix naming of security interstitial resource (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, felt, mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

fix naming of security interstitial resource R=felt@chromium.org BUG=none Committed: https://crrev.com/5f0137cc26cb83e3103a232e6a176bd4e2d2701d Cr-Commit-Position: refs/heads/master@{#299407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
Evan Stade
6 years, 2 months ago (2014-10-13 19:20:38 UTC) #1
felt
lgtm & thx
6 years, 2 months ago (2014-10-13 19:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656523002/1
6 years, 2 months ago (2014-10-13 20:43:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17323)
6 years, 2 months ago (2014-10-13 20:52:08 UTC) #6
felt
+mattm for c/b/safe_browsing
6 years, 2 months ago (2014-10-13 21:09:50 UTC) #8
mattm
lgtm
6 years, 2 months ago (2014-10-13 21:22:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656523002/1
6 years, 2 months ago (2014-10-13 21:24:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17335)
6 years, 2 months ago (2014-10-13 21:35:15 UTC) #13
Evan Stade
+thestig for browser_resources.grd
6 years, 2 months ago (2014-10-14 00:31:12 UTC) #15
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-14 00:37:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656523002/1
6 years, 2 months ago (2014-10-14 00:37:59 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 00:42:43 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:43:31 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5f0137cc26cb83e3103a232e6a176bd4e2d2701d
Cr-Commit-Position: refs/heads/master@{#299407}

Powered by Google App Engine
This is Rietveld 408576698