Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 656503005: Replace STAGE_PAIRING_DONE with STAGE_HOST_ENROLLMENT_SUCCESS. (Closed)

Created:
6 years, 2 months ago by achuithb
Modified:
6 years, 2 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Replace STAGE_PAIRING_DONE with STAGE_HOST_ENROLLMENT_SUCCESS. Handle STAGE_INITIALIZATION_ERROR with a logging message BUG=420111 TEST=manual Committed: https://crrev.com/3750071cbf4aa647647dbf2d54c0f733b76255bd Cr-Commit-Position: refs/heads/master@{#300337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/pairing/bluetooth_host_pairing_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/pairing/controller_pairing_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/pairing/fake_controller_pairing_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
achuithb
Zach, please review.
6 years, 2 months ago (2014-10-20 19:51:19 UTC) #2
Zachary Kuznia
lgtm
6 years, 2 months ago (2014-10-20 20:10:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656503005/1
6 years, 2 months ago (2014-10-20 20:32:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 21:46:40 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 21:47:22 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3750071cbf4aa647647dbf2d54c0f733b76255bd
Cr-Commit-Position: refs/heads/master@{#300337}

Powered by Google App Engine
This is Rietveld 408576698