Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 656483005: Non-SFI mode: Clean up libevent_nacl_nonsfi.gyp. (Closed)

Created:
6 years, 2 months ago by hidehiko
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Non-SFI mode: Clean up libevent_nacl_nonsfi.gyp. 1) Now, nacl_helper_nonsfi is built only when disable_nacl==0 and disable_nacl_untrusted==0. Update the condition. 2) native_client/src/public/linux_syscall is now automatically included by the PNaCl toolchain for the Non-SFI build. 3) Move include_dirs from variables to target. 4) Use relative path instead of <(DEPTH) BUG=358465 TEST=Ran trybot. TBR=darin@chromium.org Committed: https://crrev.com/30ac7557a6aadb91625266bdf615ca7b6c071680 Cr-Commit-Position: refs/heads/master@{#301062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/libevent/libevent_nacl_nonsfi.gyp View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hidehiko
This is just clean up along with NaCl roll. PTAL.
6 years, 2 months ago (2014-10-24 04:57:58 UTC) #2
Mark Seaborn
LGTM
6 years, 2 months ago (2014-10-24 05:06:29 UTC) #3
hidehiko
Thank you for quick review, Mark. +darin to R= and TBR= by following the procedure ...
6 years, 2 months ago (2014-10-24 05:27:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656483005/1
6 years, 2 months ago (2014-10-24 05:28:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 06:11:20 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 06:12:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30ac7557a6aadb91625266bdf615ca7b6c071680
Cr-Commit-Position: refs/heads/master@{#301062}

Powered by Google App Engine
This is Rietveld 408576698