Fix off-by-one in sizing of m_EmbeddedToUnicodes.

Fix off-by-one in sizing of m_EmbeddedToUnicodes.

BUG=421196
R=bo_xu@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/9dd088033537c071725b9a61fd5b519d65ea9f13

[Tom Sepez, 2014-10-13 18:48:53]

tsepez@chromium.org changed reviewers:
+ bo_xu@foxitsoftware.com, jun_fang@foxitsoftware.com

[Tom Sepez, 2014-10-13 18:48:54]

Bo, Jun, please review.

[Bo Xu, 2014-10-13 19:12:33]

https://codereview.chromium.org/656463006/diff/1/core/include/fpdfapi/fpdf_re...
File core/include/fpdfapi/fpdf_resource.h (right):

https://codereview.chromium.org/656463006/diff/1/core/include/fpdfapi/fpdf_re...
core/include/fpdfapi/fpdf_resource.h:483: #define NUMBER_OF_CIDSETS   6
I wonder if we should move the definition of g_CharsetNames in fpdf_font_cid.cpp
to here? This will make them compact and if new charset is added, they could be
both modified without overflow |charset|.

Also, maybe do "const int NUMBER_OF_CIDSETS = 6"?

[Tom Sepez, 2014-10-13 19:40:22]

https://codereview.chromium.org/656463006/diff/1/core/include/fpdfapi/fpdf_re...
File core/include/fpdfapi/fpdf_resource.h (right):

https://codereview.chromium.org/656463006/diff/1/core/include/fpdfapi/fpdf_re...
core/include/fpdfapi/fpdf_resource.h:483: #define NUMBER_OF_CIDSETS   6
On 2014/10/13 19:12:33, Bo Xu wrote:
> I wonder if we should move the definition of g_CharsetNames in
fpdf_font_cid.cpp
> to here? This will make them compact and if new charset is added, they could
be
> both modified without overflow |charset|.
g_CharsetNames strikes me as an implementation detail, and should be hidden in
the .cpp file, but what we can do instead is change the declaration to:
const FX_LPCSTR g_CharsetNames[NUMBER_OF_CIDSETS] = {NULL, "GB1", "CNS1",
"Japan1", "Korea1", "UCS", NULL};

so that adding one will cause the compile to break.

> 
> Also, maybe do "const int NUMBER_OF_CIDSETS = 6"?
The others are #defines, so I'd prefer consistency.  They should all move to
enums down the road.

[Bo Xu, 2014-10-13 20:10:11]

On 2014/10/13 19:40:22, Tom Sepez wrote:
>
https://codereview.chromium.org/656463006/diff/1/core/include/fpdfapi/fpdf_re...
> File core/include/fpdfapi/fpdf_resource.h (right):
> 
>
https://codereview.chromium.org/656463006/diff/1/core/include/fpdfapi/fpdf_re...
> core/include/fpdfapi/fpdf_resource.h:483: #define NUMBER_OF_CIDSETS   6
> On 2014/10/13 19:12:33, Bo Xu wrote:
> > I wonder if we should move the definition of g_CharsetNames in
> fpdf_font_cid.cpp
> > to here? This will make them compact and if new charset is added, they could
> be
> > both modified without overflow |charset|.
> g_CharsetNames strikes me as an implementation detail, and should be hidden in
> the .cpp file, but what we can do instead is change the declaration to:
> const FX_LPCSTR g_CharsetNames[NUMBER_OF_CIDSETS] = {NULL, "GB1", "CNS1",
> "Japan1", "Korea1", "UCS", NULL};
> 
> so that adding one will cause the compile to break.
> 
> > 
> > Also, maybe do "const int NUMBER_OF_CIDSETS = 6"?
> The others are #defines, so I'd prefer consistency.  They should all move to
> enums down the road.

lgtm

[Tom Sepez, 2014-10-13 20:16:39]

Committed patchset #2 (id:80001) manually as
9dd088033537c071725b9a61fd5b519d65ea9f13 (presubmit successful).