Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 656463002: add support for skfiddle width/height options (Closed)

Created:
6 years, 2 months ago by humper
Modified:
6 years, 2 months ago
Reviewers:
tfarina, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add support for skfiddle width/height options BUG=skia: R=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/6c07907eaa464ba98b0144ff20ea6989238b6253

Patch Set 1 #

Total comments: 8

Patch Set 2 : tfarina suggestions #

Patch Set 3 : add new db creation commands to the design documnt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -71 lines) Patch
M experimental/webtry/DESIGN.md View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M experimental/webtry/main.cpp View 3 chunks +13 lines, -4 lines 0 comments Download
M experimental/webtry/res/js/webtry.js View 4 chunks +5 lines, -2 lines 0 comments Download
M experimental/webtry/res/webtry/css/webtry.css View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/res/webtry/sass/_bootstrap-variables.scss View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/webtry/res/webtry/sass/webtry.scss View 3 chunks +58 lines, -4 lines 0 comments Download
M experimental/webtry/scripts/fiddle_run View 1 chunk +1 line, -5 lines 0 comments Download
M experimental/webtry/scripts/fiddle_wrapper View 2 chunks +3 lines, -3 lines 0 comments Download
M experimental/webtry/templates/content.html View 1 1 chunk +2 lines, -3 lines 0 comments Download
M experimental/webtry/templates/index.html View 1 chunk +7 lines, -2 lines 0 comments Download
A experimental/webtry/templates/sidebar.html View 1 chunk +25 lines, -0 lines 0 comments Download
M experimental/webtry/templates/workspace.html View 1 1 chunk +28 lines, -26 lines 0 comments Download
M experimental/webtry/webtry.go View 19 chunks +51 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
humper
PTAL -- this works on my local instance; will need to update the Cloud SQL ...
6 years, 2 months ago (2014-10-13 15:33:40 UTC) #2
tfarina
just minor comments below and one question. We may need to implement a migration step ...
6 years, 2 months ago (2014-10-13 15:50:51 UTC) #3
humper
https://codereview.chromium.org/656463002/diff/1/experimental/webtry/templates/content.html File experimental/webtry/templates/content.html (right): https://codereview.chromium.org/656463002/diff/1/experimental/webtry/templates/content.html#newcode1 experimental/webtry/templates/content.html:1: On 2014/10/13 15:50:50, tfarina wrote: > while here, lets ...
6 years, 2 months ago (2014-10-13 16:44:06 UTC) #4
jcgregorio
LGTM
6 years, 2 months ago (2014-10-13 17:48:23 UTC) #5
humper
6 years, 2 months ago (2014-10-13 17:58:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:230001) manually as
6c07907eaa464ba98b0144ff20ea6989238b6253.

Powered by Google App Engine
This is Rietveld 408576698