Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 656453002: DevTools: [SSP] show links for matched styles with spaces in source URL (Closed)

Created:
6 years, 2 months ago by lushnikov
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] show links for matched styles with spaces in source URL The patch fixes couple of workspace inner methods used for fetching uiSourceCodes based on their URL's. BUG=422073 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183686

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments #

Patch Set 3 : added testcase #

Patch Set 4 : rebaseline #

Messages

Total messages: 11 (3 generated)
lushnikov
6 years, 2 months ago (2014-10-13 15:11:22 UTC) #1
vsevik
https://codereview.chromium.org/656453002/diff/1/Source/devtools/front_end/workspace/Workspace.js File Source/devtools/front_end/workspace/Workspace.js (right): https://codereview.chromium.org/656453002/diff/1/Source/devtools/front_end/workspace/Workspace.js#newcode751 Source/devtools/front_end/workspace/Workspace.js:751: var path = decodeURI(splitURL.slice(1).join("/")); you are doing decodeURI for ...
6 years, 2 months ago (2014-10-14 07:41:05 UTC) #2
lushnikov
PTAL
6 years, 2 months ago (2014-10-14 12:03:58 UTC) #3
vsevik
lgtm
6 years, 2 months ago (2014-10-14 12:12:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656453002/110001
6 years, 2 months ago (2014-10-14 12:52:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31696)
6 years, 2 months ago (2014-10-14 16:59:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656453002/110001
6 years, 2 months ago (2014-10-14 17:08:03 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 18:10:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:110001) as 183686

Powered by Google App Engine
This is Rietveld 408576698