Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 65643012: Fix interlibrary dependencies in target shared library builds (Closed)

Created:
7 years, 1 month ago by Roland McGrath
Modified:
7 years, 1 month ago
Reviewers:
Mark Seaborn, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Fix interlibrary dependencies in target shared library builds The core change here is just the libtool.m4 change. The purpose of that is to teach libtool that *-*-nacl* is like *-*-linux* as far as the semantics of dependencies between shared libraries. The lack of this meant that libstdc++.so did not have proper dependencies on libc.so and libm.so. Fixes to the linker mean that links using --as-needed that happened to draw in libm.so as a dependency of the final nexe no longer do, leading to undefined symbol errors for libstdc++.so's references to libm.so symbols. All the */configure changes are just due to regenerating with Autoconf. The status quo ante included a hodge-podge of hand edits to the generated configure files as well as some changes to .m4 files that had then affected some configure files but not all because the person doing the change regenerated some affected files and not others. The config/lib-link.m4 change is necessary to preserve a change that was made with hand edits to configure files but should have been made in that source file instead. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3636 TEST= local build and hand examination R=sehr@chromium.org, mseaborn@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=3960379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -60 lines) Patch
M config/lib-link.m4 View 2 chunks +2 lines, -2 lines 0 comments Download
M gcc/configure View 12 chunks +32 lines, -17 lines 0 comments Download
M libgfortran/configure View 8 chunks +11 lines, -11 lines 0 comments Download
M libgomp/configure View 10 chunks +41 lines, -11 lines 0 comments Download
M libmudflap/configure View 5 chunks +19 lines, -4 lines 0 comments Download
M libobjc/configure View 4 chunks +4 lines, -4 lines 0 comments Download
M libssp/configure View 5 chunks +19 lines, -4 lines 0 comments Download
M libstdc++-v3/configure View 3 chunks +3 lines, -3 lines 0 comments Download
M libtool.m4 View 1 chunk +1 line, -1 line 0 comments Download
M zlib/configure View 4 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
7 years, 1 month ago (2013-11-16 00:01:19 UTC) #1
sehr
lgtm
7 years, 1 month ago (2013-11-16 00:10:56 UTC) #2
Roland McGrath
7 years, 1 month ago (2013-11-16 02:06:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r3960379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698