Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Unified Diff: chrome/common/extensions/docs/server2/render_servlet.py

Issue 65643009: Docserver: Attach intro metadata to the template itself, not to an object which (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/render_servlet.py
diff --git a/chrome/common/extensions/docs/server2/render_servlet.py b/chrome/common/extensions/docs/server2/render_servlet.py
index a38eb6dee7569d660297e944b19a9cea16dc3421..efdec443e0cb35bdd0b5104fb266bc47c3931a80 100644
--- a/chrome/common/extensions/docs/server2/render_servlet.py
+++ b/chrome/common/extensions/docs/server2/render_servlet.py
@@ -10,6 +10,7 @@ import traceback
from urlparse import urlsplit
from data_source_registry import CreateDataSources
+from environment import IsPreviewServer
from file_system import FileNotFoundError
from redirector import Redirector
from servlet import Servlet, Response
@@ -47,6 +48,8 @@ class RenderServlet(Servlet):
try:
return self._GetSuccessResponse(path, server_instance)
except FileNotFoundError:
+ if IsPreviewServer():
+ logging.error(traceback.format_exc())
# Maybe it didn't find the file because its canonical location is
# somewhere else; this is distinct from "redirects", which are typically
# explicit. This is implicit.

Powered by Google App Engine
This is Rietveld 408576698