Issue 65643006: Make a copy before enumerating profiles because the list might change underneath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 65643006: Make a copy before enumerating profiles because the list might change underneath. (Closed)

Created:
7 years, 1 month ago by pastarmovj

Modified:
7 years, 1 month ago

Reviewers:
rpetterson

CC:
chromium-reviews, rginda+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make a copy before enumerating profiles because the list might change underneath. If a profile is created/removed as a result of the call to AddProfile inside it will crash because the iterator is invalidated. BUG=319676 TEST=On Mac as described in the bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235736