Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 65643003: Regression fix: HForceRepresentation shouldn't be an idef. (Closed)

Created:
7 years, 1 month ago by mvstanton
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Regression fix: HForceRepresentation shouldn't be an idef. Instead, code sites that are interested in underlying constant integer values should use HValue::IsInteger32Constant(). The issue is that the infer representation phase shouldn't "see through" HForceRepresentation nodes to an underlying, and less specific representation. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M src/hydrogen.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi guys, PTAL, --Michael
7 years, 1 month ago (2013-11-15 11:21:56 UTC) #1
Michael Starzinger
LGTM.
7 years, 1 month ago (2013-11-15 11:23:45 UTC) #2
mvstanton
7 years, 1 month ago (2013-11-15 12:11:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698