Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 656423003: Remove non-applicable mojo unittests (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove non-applicable mojo unittests These targets are being developed canonically in the mojo repo and tested there, no reason to run the tests in the chromium repo. The mojo tests that should run in the chomium repository are: mojo_public_* - the mojo SDK tests mojo_system_unittests - mojo EDK tests mojo_common_unittests - tests for mojo<->chromium glue mojo_*_js_unittests - mojo JS bindings tests, which is being developed in chromium. R=sky@chromium.org Committed: https://crrev.com/269a15af86a8d75e132e02df23a6a39154cf385e Cr-Commit-Position: refs/heads/master@{#300601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M testing/buildbot/chromium.fyi.json View 7 chunks +0 lines, -17 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 8 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +0 lines, -8 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
6 years, 2 months ago (2014-10-21 21:54:47 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-10-21 22:45:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656423003/1
6 years, 2 months ago (2014-10-21 22:49:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 01:23:24 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:04:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/269a15af86a8d75e132e02df23a6a39154cf385e
Cr-Commit-Position: refs/heads/master@{#300601}

Powered by Google App Engine
This is Rietveld 408576698