Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 656353002: Make DEPS not add an extra pdfium directory. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
aneeshm
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium/+/master
Visibility:
Public.

Description

Make DEPS not add an extra pdfium directory. This makes gclient config and gclient sync work. BUG=423896 TBR=aneeshm@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fe4537269fc7133320a5131638757f2ffa6bd854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Hey Aneesh, not sure why there was an extra pdfium there? I don't see something ...
6 years, 2 months ago (2014-10-16 22:32:18 UTC) #1
jam
Committed patchset #1 (id:1) manually as fe4537269fc7133320a5131638757f2ffa6bd854 (presubmit successful).
6 years, 2 months ago (2014-10-16 22:32:32 UTC) #2
aneeshm
On 2014/10/16 22:32:32, jam wrote: > Committed patchset #1 (id:1) manually as > fe4537269fc7133320a5131638757f2ffa6bd854 (presubmit ...
6 years, 2 months ago (2014-10-17 00:00:33 UTC) #3
jam
6 years, 2 months ago (2014-10-17 05:11:51 UTC) #4
Message was sent while issue was closed.
On 2014/10/17 00:00:33, aneeshm wrote:
> On 2014/10/16 22:32:32, jam wrote:
> > Committed patchset #1 (id:1) manually as
> > fe4537269fc7133320a5131638757f2ffa6bd854 (presubmit successful).
> 
> When I first wrote the DEPS file, I did it this way.
> 
> I later changed it to include the pdfium directory prefix because I was
checking
> out pdfium from *outside* the pdfium directory.

Can that change?

How does Skia recipe do it?

> With the current change, the
> pdfium recipe no longer works; you can verify this by running
> './scripts/tools/run_recipe.py pdfium' inside build.
> 
> Do you know of any way around this problem?

Powered by Google App Engine
This is Rietveld 408576698