Allow disabling the encrypt everything option.

Allow disabling the encrypt everything option.

In certain cases, we don't want to allow encrypting all data
(AKA, the CUSTOM_PASSPHRASE type).

BUG=424187
Committed: https://crrev.com/d355b341dc90c30761681de000da4cf59cd794ac
Cr-Commit-Position: refs/heads/master@{#300029}

[maxbogue, 2014-10-16 18:07:13]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2014-10-16 20:27:06]

https://codereview.chromium.org/656333002/diff/1/sync/android/java/src/org/ch...
File
sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java
(right):

https://codereview.chromium.org/656333002/diff/1/sync/android/java/src/org/ch...
sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java:86:
* @param encryptEverythingAllowed Whether we're allowed to encrypt all data.
Try to not use pronouns in comments.

What about something like: "whether encrypting all data is allowed."

https://codereview.chromium.org/656333002/diff/1/sync/android/java/src/org/ch...
sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java:110:
* TODO(maxbogue): Remove when no longer used in Clank.
Nit: Could you also add crbug.com/424187 to this?

[maxbogue, 2014-10-16 20:30:57]

https://codereview.chromium.org/656333002/diff/1/sync/android/java/src/org/ch...
File
sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java
(right):

https://codereview.chromium.org/656333002/diff/1/sync/android/java/src/org/ch...
sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java:86:
* @param encryptEverythingAllowed Whether we're allowed to encrypt all data.
On 2014/10/16 20:27:06, nyquist wrote:
> Try to not use pronouns in comments.
> 
> What about something like: "whether encrypting all data is allowed."

Done.

https://codereview.chromium.org/656333002/diff/1/sync/android/java/src/org/ch...
sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java:110:
* TODO(maxbogue): Remove when no longer used in Clank.
On 2014/10/16 20:27:06, nyquist wrote:
> Nit: Could you also add crbug.com/424187 to this?

Done.

[nyquist, 2014-10-16 22:49:37]

lgtm

[maxbogue, 2014-10-16 22:53:17]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2014-10-16 22:54:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/656333002/20001

[commit-bot: I haz the power, 2014-10-17 00:43:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-17 00:44:56]

Patchset 2 (id:??) landed as
https://crrev.com/d355b341dc90c30761681de000da4cf59cd794ac
Cr-Commit-Position: refs/heads/master@{#300029}