Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 656323004: Android Video Capture: Refactor VideoCapture class hierarchy (Closed)

Created:
6 years, 1 month ago by mcasas
Modified:
6 years, 1 month ago
Reviewers:
qinmin, magjed_chromium
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android Video Capture: Refactor VideoCapture class hierarchy This CL refactors the current class hierarchy, currently looking sth like: VideoCapture (abstract) ^ ^--- VideoCaptureAndroid +-------- VideoCaptureTango into: VideoCapture (abstract) ^ ^---VideoCaptureCamera (abstract) | ^ ^--- VideoCaptureAndroid | +-------- VideoCaptureTango | +--------VideoCaptureCamera2 (To be introduced in parallel CLs(*)) (*) Note that http://crrev.com/611283002 only introduces static methods, so this "plugging" into this new hierarchy can be done afterwards. Some operators are also moved from end of line to beginning of the next one following presubmit warnings. Also some accessing qualifiers are revisited, and some static methods consolidated at the top of the class declaration, where they seem to belong. BUG=418052 Committed: https://crrev.com/96b7b47e058f32a913bb0f12cffa3fb80a71bde3 Cr-Commit-Position: refs/heads/master@{#301113}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -425 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCapture.java View 4 chunks +15 lines, -285 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 4 chunks +12 lines, -12 lines 0 comments Download
A + media/base/android/java/src/org/chromium/media/VideoCaptureCamera.java View 14 chunks +46 lines, -124 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureTango.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mcasas
magjed@ PTAL qinmin@ PTAL/FYI
6 years, 1 month ago (2014-10-24 09:00:35 UTC) #7
magjed_chromium
The description looks ok. If you have only moved code around according to that, lgtm.
6 years, 1 month ago (2014-10-24 11:42:16 UTC) #8
qinmin
lgtm
6 years, 1 month ago (2014-10-24 15:12:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/656323004/90001
6 years, 1 month ago (2014-10-24 15:14:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:90001)
6 years, 1 month ago (2014-10-24 16:08:33 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 16:09:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96b7b47e058f32a913bb0f12cffa3fb80a71bde3
Cr-Commit-Position: refs/heads/master@{#301113}

Powered by Google App Engine
This is Rietveld 408576698